Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for PHP 7.4 #3004

Merged
merged 3 commits into from May 14, 2019
Merged

Fix support for PHP 7.4 #3004

merged 3 commits into from May 14, 2019

Conversation

fabpot
Copy link
Contributor

@fabpot fabpot commented May 14, 2019

No description provided.

@fabpot fabpot mentioned this pull request May 14, 2019
Closed
@fabpot fabpot merged commit f958bd1 into twigphp:1.x May 14, 2019
fabpot added a commit that referenced this pull request May 14, 2019
@fabpot
bug #3004 Fix support for PHP 7.4 (fabpot)
611a29c 
This PR was squashed before being merged into the 1.x branch (closes #3004).

Discussion
----------

Fix support for PHP 7.4

Commits
-------

f958bd1 fixed deprecation under PHP 7.4
1fb0f97 fixed PHP 7.4 support
7be8e94 added PHP 7.4 in Travis config
@fabpot fabpot deleted the php74-support-fix branch May 14, 2019 07:02
@stof stof mentioned this pull request Jan 21, 2020
Closed
weaverryan added a commit to knpuniversity/javascript that referenced this pull request Apr 30, 2020
@weaverryan
upgrading Twig to 2.10.0 to fix PHP 7.4 compat
b289638 
twigphp/Twig#3004

The "select" menu was rendering without a space:
    <selectid="...">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@fabpot